revert: remove extension points to get/update extended profile fields in the account settings - #45
Open
efortish wants to merge 1 commit into
Open
Conversation
…he accounts page" This reverts commit 3b21ebf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: https://github.com/fccn/nau-technical/issues/875
This PR removes the extension points responsible for retrieving and updating extended profile fields in the account settings.
NAU_STUDENT_ACCOUNT_PARTIAL_UPDATENAU_STUDENT_SERIALIZER_CONTEXT_EXTENSIONNAU_STUDENT_ACCOUNT_CONTEXT_EXTENSIONThis is made in favor of using upstream changes in edx-platform instead (openedx/openedx-platform#37119)
Note
This new way of defining extended fields is already working in Nau teak deployments!
Related PR: fccn/nau-openedx-extensions#146